Hi Peter,

Yes, we should remove them, but you could filter all such warnings from the Gnutella package.

Ok, I’ve added them to the ignore list for now.

value_ is non-pointer member. Could you look more into that please?

The official Intel compiler docs says about this warning:

Use delete on pointer members in destructors. The compiler diagnoses any pointer that does not have a delete.

And this is what one would expect, but as I wrote, this warning appears also in classes with no pointer members at all… I haven’t found anything about this on the Internet neither.

I’d suggest that we tag all classes with one of: REFERENCE_OBJECT, VALUE_OBJECT, STATIC_HELPER. Maybe we could also create a custom Doxygen command (seems to be possible to be defined in Doxyfile) and tag also the docs.

I agree!

./Gnutella/LocalPeer.h(36): warning #64: declaration does not declare anything
class UIs::Searching::SearchModel;

What’s the exact meaning of this warning? That the forward declaration is unnecessary because the the class is fully specified already?

No, in this case it means that class UIs::Searching::SearchModel was already declared in the imported UIs/Searching/Namespace.h header. The warning itself (it’s “name”) is a little bit awkward, though.

Declaration of “some variable” shadows a member of ‘this’

We should enforce the memberName_ naming convention

Yes, I agree, especially when not using PrivateData class as a private data storage.

Please fix as many warnings as you can in your branch and I’ll merge all your revisions at once.

Maybe you could also update your calitko-dev branch and also fix all remaining BitTorrent warnings. I’ll do the same to fix the warnings in Utils::ObjectDispatcher.

Ok, I’ve fixed nearly all warnings (except these in the Gnutella package) - the latest revno is 219. I’ve fixed them in my calitko-dev branch, so I could fix also nearly all warnings in the BitTorrent package. I’ve also merged my calitko branch, so you don’t have to merge it - you can merge only my dev branch.

I’ve also updated our ignored warnings lists - I’ll soon update the wiki documentation to be up to date.

You can take a look into the attached file for a short list of warnings that still need to be fixed, nevertheless I’m really glad the we managed to fix nearly all warnings ;). There are still some problems, though (see TODOs in linux-icc.txt file).

Regards,

Petr