Re: compilation.py feedback

Hi Petr,

Thanks for the comments!

I think that only warnings are printed, but errors are not (this will require just updating the isWarningRegexp regexp, or adding some other regexp that will cause errors printing without any checking).

Not filterin errors will not be a problem. I was actually thinking that the use scenario for the script would be to make the complete project using it once you can compile without errors, collect a log of all warnings and then fix then one after the other. This would be done occasionally, e.g. before merging a branch to the mainstream. I guess you rather intended to use it regularly as part of your own development, in which case filtering ONLY excluded warnings and related non-warning lines would be better. I think that the latter use scenario would be more difficult to implement. If you agree, let us optimize the script for the former scenario - occasional runs to verify code quality and standards conformance.

(we can remove the Solve the problem with ‘instantiated from here’ and ‘when initialized here etc. problem)

OK! I’ll fix that.

Hmm, I can’t think of any right now - I first thought that they will be needed in such cases, but as we can simplify these regexps, maybe we really could drop the support for them (also the script will become more simple).

OK, will do so!

Final question, what is the following regexp for?

.*generators.*

Maybe it’s to exclude 3rdParty/moc/generators… should we exclude everything from 3rdParty instead?

Regards,

Peter

Would you like to post a relpy?


This post is a reply to:
Re: compilation.py feedback
Hi Peter, I like the changes you've made! I've noticed two things, though: I think that only warnings are printed, but errors are not (this will require just updating the isWarningRegexp regexp, (more...)

Follow-ups:
Re: compilation.py feedback
Hi Peter, I guess you rather intended to use it regularly as part of your own development, in which case filtering ONLY excluded warnings and related non-warning lines would be better. (more...)