Re: TrackerManager - what should be passed to the start() func?

Hi Petr,

I’d maybe name the first two sessions SingleTrackerRequestSession and MultiTrackerRequestSession (according to these specs, there is also written “multitracker”). What do you think?

That sounds great! The tests look good too! The only thing that seems to be missing is using a timer for the next tracker announcement. I’ve defined and used a Timer interface in Choker and its tests. Maybe you could use it too? That would require you to merge my branch because of Callable, or you could copy-paste the Timer declaration and replace the Callable parameter temporarily with an int.

Actually I initially thought that the TrackerManager will manage multiple trackers itself but the solution with a MultiTrackerRequestSession seems so much better. TrackerManager is quite simple now and this is really good!

Regards,

Peter

Would you like to post a relpy?


This post is a reply to:
Re: TrackerManager - what should be passed to the start() func?
Hi Peter, I'll refer to my last changes in this post. I think passing the Torrent object to start() gives us most flexibility. I could think that the Torrent object gets (more...)

No follow-ups yet.