Hi Peter,

I’ve fixed nearly all (”fixable”) warnings in the Protocols::BitTorrent::{Bencoding,Torrents,Trackers} packages and I’ve found some things which I’d like to discuss.

Protocols/BitTorrent/Trackers/TrackerRequestUrlCreator.cpp:110: warning: switch missing default case
I haven’t noticed that since now. Because we haven’t added a default case (on purpose), maybe we could add this warning to our “warnings list”. Another solution would be to add that case…

I’ve tried to generate a doxygen docs and I saw that after updating all “value object type” classes to use our macro, doxygen won’t generate docs for these member functions (namely comparison operators, copy ctor and assignment operator) because they’re missing in the class definition in the header file. I’m not sure whether it’s possible to enable this feature in the Doxygen config file - if not, maybe we should consider a possibility to remove this macro and use only the two remaining - STATIC_HELPER and REFERENCE_OBJECT.

The last thing I noticed is that the “class type” macro from Qt.h is not shown in the generated docs - it’s visible only in the source code, so (probably) the only possible way is to add a text comment to the class description.

So, what’s your opinion about these things?

Good night,

Petr