By Peter Dimov (15. July 2007, 16:18:19)
Re: PeerInfo and PeerId
 (25 )

Hi Petr,

The revision looks pretty good!

The only thing I noted was that instead of implementing the custom function getPeerIdFromPeerInfo() we could use the new Uri::queryItemValue (const QByteArray &key) which will return the value associated with the key or a QByteArray() is none is associated.

Btw, I liked that one:

Q_ASSERT (false && “peerInfo does not contain peer ID!”);

I think I’ll be writing my Q_ASSERT (false) like this from now on! :-)

Regards,

Peter

Would you like to post a relpy?


This post is a reply to:
By Petr Zemek (15. July 2007, 10:42:56)
Re: PeerInfo and PeerId
 (26)
Hi Peter, I've pushed changes according to our discussion. I've replaced PeerInfo class with Uri class - see PeerInfo.h for more details. In the TrackerResponseParser I'm testing whether all 'peers' fields (more...)

Follow-ups:
By Petr Zemek (15. July 2007, 17:30:44)
Re: PeerInfo and PeerId
 (24)
Hi Peter, The only thing I noted was that instead of implementing the custom function getPeerIdFromPeerInfo() we could use the new Uri::queryItemValue (const QByteArray &key) which will return the value associated (more...)