By Petr Zemek (5. July 2007, 13:53:56)
Re: templater
 (4 )

Hi Peter,

it’s great that you’ve already changed some inconsistent files! I’ve made a few changes according to your suggestions, comments are below.

Here are some small things that I saw though. For example,

./Protocols/BitTorrent/Packets/Testing/Imports.h

Seems to be checked twice. I haven’t looked into that, I thought maybe you would know why that could be happening. Maybe for each module its package Imports are checked again?

You’re right - for each module its Imports.{cpp,h} files are checked again. I’ve implemented a warnings buffer, so each warning message will be displayed only once.

I’d suggest that no warning is displayed if ModuleTest.h is missing. In most cases we won’t need a header for the tests. It makes more sense to require having Testing/Imports.h though. What do you think?

Ok - I’ve added a constant/variable DefaultTemplateOnlyOptionalItemsRegexps/onlyOptionalItemsRegexps to the TemplatesProperties class, which is a list of regexps and if any missing file matches some regexp in that list then no warning message is displayed. Currently there is only one regexp that matches files like Testing/ModuleTest.h.

Have a nice day,

Petr

Would you like to post a relpy?


This post is a reply to:
By Peter Dimov (5. July 2007, 01:34:22)
Re: templater
 (5)
Hi Petr, The checker is doing a really amazing job! It's really great you wrote it and I think we will be using it a lot! It contributes to ensuring that (more...)

Follow-ups:
By Peter Dimov (5. July 2007, 21:59:20)
Re: templater
 (3)
Hi Petr, You’re right - for each module its Imports.{cpp,h} files are checked again. I’ve implemented a warnings buffer, so each warning message will be displayed only once. Wouldn't it be better (more...)