By Peter Dimov (2. July 2007, 18:20:52)
Re: TrackerRequestDriver feedback
 (2 )

Hi Petr,

Just checked your rev 140:

\todo Add assertions/validations for hash info and peer ID (these
have to be correctly set and must be exactly 20B long)

and I thought that we actually need and would need this thing quite often. For example Protocols::Generics::VendorCode is just that - 4 byte QByteArray. We could make a template out of it - something like FixedByteArray taking an int as a template argument. They we could define VendorCode as a typedef for FixedByteArray <4>. Similarly we could define RawPeerId as a typedef for FixedByteArray <20>

What do you think?

Regards,

Peter

Would you like to post a relpy?


This post is a reply to:
By Petr Zemek (29. June 2007, 14:28:00)
Re: TrackerRequestDriver feedback
 (10)
Hi Peter, The Qt docs state explicitly that a conversion to and from UTF-8 takes place. That even seems correct according to RFC-3986: ... I didn’t find any reference to UTF-8 in RFC-1738 (more...)

Follow-ups:
By Petr Zemek (2. July 2007, 19:09:42)
Re: TrackerRequestDriver feedback
 (1)
Hi Peter, Just checked your rev 140: [cut] and I thought that we actually need and would need this thing quite often. For example Protocols::Generics::VendorCode is just that - 4 byte QByteArray. We (more...)