Re: Additional compiler warnings list

Hi Petr,

You can check my new branch at http://bzr.calitko.org/developers/s3rvac/calitko/ - I’ve fixed all errors that are produced when compiling with `std=c++98 -pedantic -Wno-long-long` so it can be compiled now according to the c++98 standard! See changeset for more info.

That’s great! Just pushed your revision to the official branch!

It turns out I have lied in rev 113 and I have only had the header files stripped from trailing spaces. I guess I have incorrectly filtered the the cpp files but it’s good you’ve fixed that too!

I’ve also tried to compile the whole project with our extra warnings enabled and after “grepping out” 3rdParty and Qt warnings the compilation produced about 5000 warnings :) - qt4 itself produced about 17000 warnings. Most of them are pretty much the same (missing member initialization in the constructor initialization part, use of an old-style cast or some overriding issues) - I haven’t studied it deeply, yet, but we should check some of them out in the future.

We definitely should! At least for the stuff in Protocols, the rest will be refactored almost completely over time anyway.

Regards,

Peter

Would you like to post a relpy?


This post is a reply to:
Re: Additional compiler warnings list
Hi Peter, I converted your warnings.txt file into extra-warnings.prf and added it to the project in rev 114. This qmake project feature is disabled by default and if someone wants to (more...)

No follow-ups yet.