Re: Protocols/Generics/ review

Hi Petr,

I just noted I have forgotten to comment on this:

- I’d move SocketTransport class members initialization into the initialization part of the constructor.
- I’d add const modifiers to canRead(), nextReadChunk(), nextReadChunkSize(), canWrite(), nextWriteChunk() and nextWriteChunkSize() functions (there is not written that they may possibly change object data).

Agreed! I was updating the docs (added \param for each param) and noticed that Markus also suggested that we get rig of setReadBufferSize(), setWriteBufferSize() which also makes sense as they are only called by the ctor. I think these SocketTransport refactorings would be a good start for someone new. I’ve created a ticket for it.

Regards,

Peter

Would you like to post a relpy?


This post is a reply to:
Protocols/Generics/ review
Hi Peter, I've wrote this during my Protocols/Generics review so the result is a "bunch" of questions or ideas about the code/design/documentation that have come on my mind. General: - I see (more...)

Follow-ups:
Re: Protocols/Generics/ review
Hi Peter, I have some more question. Why is the documentation in the implementation file? I was thinking it is in the header file. How can I produce a documentation with (more...)