By Peter Dimov (23. December 2006, 23:24:06)
Re: SourceComment: Refactoring makes code beautiful ;-)
 (0 )

Hi Atul, that patch looks quite neat! I really like this kind of refactoring of yours where you split a more complex function into smaller parts and call these smaller parts instead. The code is so much readable this way. I might have an idea how using the functor would not be necessary but will have to try it out… and let you know.

The patch is pushed in revno 94 of your public branch.

Regards, Peter

Would you like to post a relpy?


This post is a reply to:
By atul (22. December 2006, 14:35:08)
SourceComment: Refactoring makes code beautiful ;-)
 (1)
Hi all Here is a patch where I have removed a long method Http::Header::parse with smaller methods.... IMHO, such code is easier to unit test, easier to understand and looks better... ( (more...)

No follow-ups yet.