By Peter Dimov (13. December 2006, 23:37:50)
Re: SourceComment: Spotting and removing duplication…
 (0 )

Hi Atul! Thanks for the patch! I pushed it in revno 90 of your public branch. Totally agree that checking for 0 is not needed before a delete.

Regrads,Peter

atul wrote:

Dear all

I introduced

void TcpConnection::startTimer() and
void TcpConnection::stopTimer()
and I think this removes some duplication and makes the code more readable…. It also has the previous change ( not checking pointer for null before deleting )
– cheerio atul

Would you like to post a relpy?


This post is a reply to:
By atul (13. December 2006, 11:27:48)
SourceComment: Spotting and removing duplication…
 (1)
Dear all I introduced void TcpConnection::startTimer() and void TcpConnection::stopTimer() and I think this removes some duplication and makes the code more readable.... It also has the previous change ( not checking pointer for null (more...)

No follow-ups yet.