By Peter Dimov (2. September 2006, 20:41:04)
Bugfix: HandshakeSession emitting the signal handshakingFailed() twice
 (1 )

I found and fixed a bug in HandshakeSession. It sometimes happened that failed() was called twice for the same HandshakeSession object, for example when the remote node rejected us and directly closed the connection. Calling failed() twice resulted in emitting handshakingFailed() twice, which lead to Handshaker deleting the session object twice!

As of this patch, if handshaking fails due to some error, then we close the connection and defer emitting handshakingFailed() until the connection gets actually closed. That would have happened when we enter the slot connectionClosed(). From there the signal handshakingFailed() will be emitted unless we have already emitted handshakingCompleted() – possible if events get queued by Qt in a specific order. If that happened, then the Connection will not be in ConnectedState when creating a new PacketSession object. In this case the new PacketSession should directly be closed (that’s on my TODO list now).

Regards,

Peter

Attached Files:

calitko-0.5.3-HandshakeSession.patch 3K

Would you like to post a relpy?


This post starts a thread.
Follow-ups:
By Peter Dimov (8. September 2006, 19:30:05)
Re: Bugfix: HandshakeSession emitting the signal handshakingFailed() twice
 (0)
In the last HandshakeSession related patch I fixed a bug that caused failed() to be called twice. I also added a Q_ASSERT in the very beginning of failed() that asserts (more...)