Some more tests added and refactored…

Hi all

I think this version of TestHttpHeader is much better than the previous one. All the test code is much simplified and just contain theĀ  assertions… Fixtures help a lot here.

I removed some duplication in BDecoderTest too… I removed theĀ  length typeid and instead have put in the testing of the pointer value… so the typeid tests are still there but the type is instead checked by the dynamic_cast.

It is amazing how removing two lines of duplication simplifies the code a lot ;-) I still don’t like that separate hasReadAll() and hasReadPassEnd() — shouldn’t it be hasReadPastEnd ;-)

Let me know what you all think… and happy weekend to you all ;-)
—- cheerio atul

Attached Files:

Would you like to post a relpy?


This post starts a thread.
Follow-ups:
Re: Some more tests added and refactored…
Hi Atul, I just pushed your latest patch in revno 89 in your public branch. In one of your previous patches you added: #ifndef UNIT_TEST qDebug() < < "dict: key value not ok"; #endif Initially, when (more...)