By Peter Dimov (6. December 2006, 11:04:54)
Re: SourceComment: Getting rid of needless conversions?
 (0 )

Hi Atul,

I agree with your suggestions, see revno 86 of your branch or the attached patch. I made ultrapeerSlots and leafSlots uchars but kept the interface (ctor and getters) with the int. The ctor takes care of the correct conversion from uchar to int (using std:min ;-)).

Regards,

Peter

atul wrote:Hi all

Do we really need UltraPeer::Data::ultrapeerSlots and UltraPeer::Data::leafSlots to be ints?

If we make them as uchar then we can use them in place in the streaming operator..

— cheers atul

Would you like to post a relpy?


This post is a reply to:
By atul (5. December 2006, 14:04:15)
SourceComment: Getting rid of needless conversions?
 (1)
Hi all Do we really need UltraPeer::Data::ultrapeerSlots and UltraPeer::Data::leafSlots to be ints? If we make them as uchar then we can use them in place in the streaming operator.. --- cheers atul

No follow-ups yet.