By atul (5. December 2006, 12:52:10)
Re: SourceComment: Let the library do the work..
 (1 )

Dear all,

I was able to do it…
Here is the latest patch… I think this idea is applicable elsewhere

( other places ref counting is done… )

– cheerio atul

atul wrote:

Dear all

While browsing thru the code I found these two small refactorings…. Thanks to the tests as they told me where I went wrong ;-)
P.S. I, very much wanted to use qAtomicDetach in
Packet::invalidateHeader(). Elevating Packet::Data to a class status would let us use it… but, opinions vary - CHUCKLE ;-)

— cheerio atul

Attached Files:

mychanges.diff 1K

Would you like to post a relpy?


This post is a reply to:
By atul (5. December 2006, 12:43:00)
SourceComment: Let the library do the work..
 (2)
Dear all While browsing thru the code I found these two small refactorings.... Thanks to the tests as they told me where I went  wrong ;-) P.S. I, very much wanted to (more...)

Follow-ups:
By Peter Dimov (5. December 2006, 13:29:09)
Re: Re: SourceComment: Let the library do the work..
 (0)
Hi Atul! I pushed the second patch in revision 84 of your public calitko-Gnutella branch. Regarding you Packet::Data command, we don't necessary need to promote it to a full-pledged class if (more...)