Hi Atul,
I thought at first that would be nice but I just tried out to declare binaryReader a member variable instead of a pointer and figured out that we’ll have to add the #include “…/BinaryReader.h” line in Imports.h, which would propagate the dependency to all header or source files that include BDecoder.h. In my opinion we should try to avoid these unnecessary dependencies even if that would cost us writing an otherwise unnecessary dtor. Would you agree?
I committed the latest Torrents patch on your public branch (rev 82):
http://bzr.calitko.org/developers/atul/calitko-Gnutella
I’ll commit your new test there as well in a while.
Btw this kind of work, when each small step comes after the other, is really great! That’s the power of peer preview ;-) I wish more people participated!
Regards,
Peter
