SourceComment: BinaryReader - Remove duplication ;-)

Hey all

This is one of my favourite refactorings ;-) If you can get “Working with Legacy Code” by Feathers, there is a fascinating chapter in which he just removes duplication and the design just comes out … It was one of the Aha! moments for me ;-)
Here is the patch …. All the tests pass, btw ;-)

— cheerio atul

Attached Files:

Would you like to post a relpy?


This post starts a thread.
Follow-ups:
Re: SourceComment: BinaryReader - Remove duplication ;-)
Hi Atul, Thanks for the patch! The functions look so much simpler now ;-)! I allowed myself to make the new functions inline and thus give the compiler a clue where (more...)