Hi Atul,

Thanks for the patch! Just committed it in revno 68. I decided to save a roundtrip and changed indentation (maybe you used tab size of 2), fixed a memory leak in testAssign() and modified testReadHeader to use QBuffer instead of a file to avoid the risk of having problems with reading/writing the temp file.

I think you also had a patch for ByeTest.cpp which had some issues left and isn’t committed yet. Maybe we should dig in the archives?

Regards,

Peter

atul wrote:Hi all

I added the tests to the Testing directory….

The

#ifdef UNIT_TEST

protected:

#else

private:

#endif

idea is taken from Mike Feather’s book ;-)

— cheers atul