Re: Re: BDecoder - ready

Hi,

I think I may have made a mistake here, there are virtual dtor’s - I was just browsing the .patch file so the full class was not in it.

Cheers/Anders.

anders44 wrote:

[8] Generally speaking any class that is inherited from should have a virtual destructor. In your BItem you don’t have a virtual _dtor.

[9] Why are not functions encapsuled in try/catch. In general there seems to be lacking exception and error handling. Best is to detect errors as soon as possible and not ignore anything.

HTH/AJK.

Would you like to post a relpy?


This post is a reply to:
Re: BDecoder - ready
Hi, I am new to this project to checkout code so I started out looking at your code but do not have the full picture yet so bare with me if (more...)

No follow-ups yet.