Hi Valeriy,

Thanks for the patch! You’ve done some great work there!

Just a few minor issues:

• You made UIs a subdir of Gui. What I actually meant was UIs to be a top-level pachage. Everything in Gui should be refactored and better organized in UIs.
• The .vcproj file couldn’t be patched, all chunks failed. You probably used an older version of .vcproj for the patch.
• Could you please rearrange the lines in calitko.pro you changed, so that all filenames are alphabetically ordered?
• Please additionally attach the new icons. Binary files are not included in patch files.
• It’s great you connected the signal returnPressed() to startSearchButtonPressed(). That was missing before. I think I’ve seen either in a Qt tutorial or in a demo video that one can connect returnPressed() to a button’s animateClick(). The result is a nice visual effect ;-).
• Lastly, you’ve used SearchingWidget, which is indeed a QTabWidget, as the “top-level” widget. What I meant was to add the searching widget as a tab to the main tab widget. The result would be two levels of tabs. That’s not urgent and you could leave that for later but here is the background: Some time ago I discussed some GUI and usability issues with Mihail Mihaylov. He suggested that the top-level widgets (network, searching, transfers, etc.) be contained in a tab widget, which has its tabs to west, i.e. setTabPosition (QTabWidget::West)) and keep the default tab position for thier tabs (SearchingWidget, for example). Maybe you could try that out, Valeriy, and see how it looks like?

Did anybody else look into the patch? Maybe someone of you guys found some other issues/bugs? I consider it very important that all changes be very well revised before they are committed in mainstream code. The reason is that once the changes are committed, it is less probable that anyone looks at the code later ;-) and peer review is the best way to get rid of bugs as early as possible ;-).

Regards,

Peter

Valeriy Provalov wrote:Hi all,

I started doing refactoring of GUI and first patch is ready:

• Create UIs/Searching/ directory, all searching stuff moved there
• Added SearchingWidget and SearchQueryView classes
• Added two TAB-icons for network and packets dump

Peter, I’m not sure, I’ve done everything correct, because of that bazzar “moving” functionality :-) Please, check it, and write me, if I need something to fix. Beside MSVC project, I also patched QT “pro”, but didn’t touched Eclipse and KDevelop.