Calitko is currently not multithreaded. I agree that static should be avoided. Declaring static PacketInfo *packetInfo and using it as an auto variable is actually crap! I’ve deleted the static in revision 56! Thank you! Keep up finding such stuff!

Btw PacketModel is related to the packet dump view and is currently disabled. It requires some work to get it working again and definitely some further refactoring.

It might make sense to run different network implementations in different threads to be able to take advantage of multi-core processors. But that’s just an idea for later.

atul wrote:Dear all,

And if so, we have to be extra careful about using static in methods….

It came to my mind as we are linking with -lpthread.

( reference ->

QVariant PacketModel::data (const QModelIndex &index, int role) const

)

— cheers atul