By Peter Dimov (5. October 2006, 19:05:27)
Re: patch to refactor away Packet::name
 (5 )

Thanks Atul! I just fixed the whitespace around parentheses and aligned the code a little. Committed in revision 53!

atul wrote:Dear Peter,

I made Packet::name pure virtual. By doing this refactoring I discovered that IbmcDescriptor, OpenVendorDescriptor and StandardVendorDescriptor are not used — What I mean is there are no concrete derivations for them…

However, the UnownPacket::name returns the correct name,

( the semantics of Packet::name() are preserved ;-)….
—- cheers atul

Would you like to post a relpy?


This post is a reply to:
By atul (5. October 2006, 15:38:15)
patch to refactor away Packet::name
 (6)
Dear Peter, I made Packet::name pure virtual. By doing this refactoring I discovered that IbmcDescriptor, OpenVendorDescriptor and StandardVendorDescriptor are not used -- What I mean is there are no concrete derivations (more...)

Follow-ups:
By atul (6. October 2006, 08:08:32)
Re: Re: patch to refactor away Packet::name
 (4)
Hey Peter,         Why not give Gnu indent a shot - so all of us can submit patches in a uniform syntax....          ---- cheers atul Peter Dimov wrote: Thanks Atul! I just fixed the whitespace (more...)