Proposed refactoring…

static QString toString (const QByteArray &ba)
{
   int len = ba.count();
    QString result;

for (int i=0; i
    }
result.append( ba );
return result;
}

I went thru the docs of QString::append(  const QByteArray &  )  and it uses  fromAscii ….  This  differs from  the original…. ( and i  think is correct in case unicode is in effect … )

— cheers atul

Would you like to post a relpy?


This post starts a thread.
Follow-ups:
Re: Proposed refactoring…
Thanks Atul! This function is in PacketMonitor.cpp. I don’t even remember writing it. It actually makes no sense at all and is never used. I deleted it in revision 54! atul (more...)