Archive for 15. July 2007

Re: PeerInfo and PeerId
Hi Peter, Now that I looked at TrackerRequestWriter in more detail I’m thinking whether or not it would be a good idea to make this class a static helper. So instead (more...)
Re: PeerInfo and PeerId
Hi Petr, Btw, what is your opinion about the TrackerRequestWriter::getPathForHttpHeader() function and the \todo there? Sorry I've overseen that! I actually only checked the changeset and not all the source code. Now (more...)
Re: PeerInfo and PeerId
Hi Peter, The only thing I noted was that instead of implementing the custom function getPeerIdFromPeerInfo() we could use the new Uri::queryItemValue (const QByteArray &key) which will return the value associated (more...)
Re: PeerInfo and PeerId
Hi Petr, The revision looks pretty good! The only thing I noted was that instead of implementing the custom function getPeerIdFromPeerInfo() we could use the new Uri::queryItemValue (const QByteArray &key) which (more...)
Re: TDD - feedback
Hi Petr, Thanks for the reply! I will write a separate TDD detailed tutorial that presenst the process of developing TcpSocketBuffer completely including all steps and refactorings. I have that on my (more...)
Re: PeerInfo and PeerId
Hi Peter, I've pushed changes according to our discussion. I've replaced PeerInfo class with Uri class - see PeerInfo.h for more details. In the TrackerResponseParser I'm testing whether all 'peers' fields (more...)