Hi Petr, - We can’t guarantee that to the FixedByteArray constructor one wouldn’t pass array with different number of bytes (or to some member function, if any), so we should think (more...)

Hi Peter, Just checked your rev 140: [cut] and I thought that we actually need and would need this thing quite often. For example Protocols::Generics::VendorCode is just that - 4 byte QByteArray. We (more...)

Hi Petr, Just checked your rev 140: \todo Add assertions/validations for hash info and peer ID (these have to be correctly set and (more...)

Dear all, I thought that would be a fun read for you too! :-) http://tarmo.fi/blog/2005/09/09/dont-draw-diagrams-of-wrong-practices-or-why-people-still-believe-in-the-waterfall-model/ Regards, Peter

Hi Petr, Maybe the built binary should be copied to AppData by make? I was thinking that only application data (icons, images, …) would be there at first (more...)

Hi Peter, I think I’d call Sources Calitko. Maybe CalitkoMocks better be in . or in ./Utils - the idea is that it eventually becomes a standalone library.Maybe the built binary (more...)

Hi Petr, Thanks for the review! Comments are inline: As for these UTF-8 conversions - I’d personally first make our Uri class using only ASCII characters (because this is what we currently (more...)

Hi Petr, I’m thinking about something like this, you can check it out, too: - 3rdParty (cppunit, moc, qmake) - Sources (Protocols, UIs, Utils, CalitkoMocks, …) - Utils (templater and other possible stuff that (more...)

Hi Peter, I've checked the Uri class and below are my ideas/comments to the current code. I must say that the idea with the Uri class was really briliant! I'm sure (more...)