Hi Petr,
I wanted to make a detailed review of your branch before I do the merge. I have done some minor modifications which I've commented below. Let me know if (more...)
Hi Peter,
- we have to comment each pre/post condition manually (and synchronize comments according to changes in the code)
I think that the positive aspect here, when we manually note the (more...)
Hi Peter,
thanks for the links! Now I see that there was a misunderstanding from my side over my "understanding" of reference objects. So, I've read some of the posts in (more...)
Hi Petr,
- creating (converting) tracker GET requests into QByteArray (class TrackerRequest) - specs
Maybe you could try creating a TrackerRequestSession? You pass it the announce URL and the TrackerReqeust. TrackerRequestSession then (more...)
Hi Petr,
Thanks for your comments!
- to ensure that a user will pass some object to the function and not just a NULL pointer (public interface)
- to ensure that a user (more...)
Hi Peter,
because you have the best overview over the whole project, I'd like to ask you what could I do as a next step. I've browsed through the specifications (more...)
Hi Peter,
OK, so I changed PacketBase fist, then went ahead to change the templates. Then I realized that the derived (generated) cannot return auto_ptr <DerivedPacket> because it is not polymorphic (more...)
Hi Petr,
I think it will be really nice and extremely helpful to have a discussion on the topic. Hopefully others will join too.
- we have to comment each pre/post condition (more...)