Archive for 13. December 2006

Re: SourceComment: Spotting and removing duplication…
Hi Atul! Thanks for the patch! I pushed it in revno 90 of your public branch. Totally agree that checking for 0 is not needed before a delete. Regrads,Peter atul wrote:Dear all I (more...)
Branches updates…
Hello everybody, I was hurrying to do the v0.5.7 release and didn’t announce the final changes, so I’m doing that now ;-) I merged the branches of Atul, Valeriy, David and mine (more...)
Calitko v0.5.7
SourceComment: Spotting and removing duplication…
Dear all I introduced void TcpConnection::startTimer() and void TcpConnection::stopTimer() and I think this removes some duplication and makes the code more readable.... It also has the previous change ( not checking pointer for null (more...)
SourceComment: Don’t check for null before delete
Dear all Instead of TcpConnection::~TcpConnection() { ...     if (socket) { socket->disconnect (this); delete socket; } if (timer) { delete timer; } have if (socket) socket->disconnect (this); delete socket; delete timer; -- cheerio atul
More HttpHeaderTests and refactored testReadTorrent
Dear all I discovered some more Http header tests. Let me know what you think ( I am a bit hazy about testHeaderFieldOnMultipleLines() --- let me know what you all think... ) While (more...)