Archive for 5. December 2006

SourceComment: Getting rid of needless conversions?
Hi all Do we really need UltraPeer::Data::ultrapeerSlots and UltraPeer::Data::leafSlots to be ints? If we make them as uchar then we can use them in place in the streaming operator.. --- cheers atul
SourceComment: Use lib wherever possible ;-)
Hi all Here is one more .... using std::min --- cheers atul
Re: SourceComment: Similar refactorings…
Thanks, Atul! Pushed the patch to revno 85 of http://bzr.calitko.org/developers/atul/calitko-Gnutella. Regards, Peter atul wrote:Dear all I applied similar reasoning to Ultrapeer::operator=. This patch also includes the change for declaring variable inside if (more...)
Re: Re: SourceComment: Let the library do the work..
Hi Atul! I pushed the second patch in revision 84 of your public calitko-Gnutella branch. Regarding you Packet::Data command, we don't necessary need to promote it to a full-pledged class if (more...)
SourceComment: Similar refactorings…
Dear all I applied similar reasoning to Ultrapeer::operator=. This patch also includes the change for declaring variable inside if conditional... --- cheers atul
Re: SourceComment: Let the library do the work..
Dear all, I was able to do it... Here is the latest patch... I think this idea is applicable elsewhere ( other places ref counting is done... ) -- cheerio atul atul wrote: Dear all While browsing (more...)
SourceComment: Let the library do the work..
Dear all While browsing thru the code I found these two small refactorings.... Thanks to the tests as they told me where I went  wrong ;-) P.S. I, very much wanted to (more...)