Hallo everyone, After reading some code, I started to do some unit test now, so that I can become familiar with the code. Because I have worked in C for a long (more...)

Hi Atul, I read again about Feature Envy. A short overview is available at http://sis36.berkeley.edu/projects/streek/agile/bad-smells-in-code.html#FeatureEnvy. Unfortunately I don’t have the Refactoring book from Martin Fowler, et al, which (more...)

Hi Atul, you are perfectly right about this refactoring! If we go a step further we can get rid of type() altogether and use the RTTI instead. For example: if (more...)

Here is a modified patch of Atul's BDecoder refactoring. I modifed BinaryReader::readString() and use it instead of the new BinaryReader::indexOf(). Additionally, BDecoder::readString() was refactored to use tryReadInt(). All tests (more...)

Dear all While reading BDecoder code, I came upon this class. I think we are storing redundant type info here.... Here is a patch that removes a lot of code Let me know.. Btw, (more...)

Hi Atul, I think I see now what is causing the confusion! The handle example actually returns a copy of the handle. Nevertheless the handle is actually a pointer to an (more...)

Dear Peter I will read Item 42 again and compare notes with what you suggest...  Btw, I was referring to the first example ( socket::handle_ ) and our code and not (more...)

Dear all http://www.objectmentor.com/resources/articles/xpepisode.htm       When I first read this I was immediately hooked... This is rocking great stuff... I booked a conf room and presented this gem of a work to (more...)

Dear Atul, I now see your point about using a struct instead and that makes sense to me. I’ll take my time to look at least at some of the references (more...)

Dear Peter The post addresses point 1 ... I will deal with point 2 in another post... --- cheers atul atul wrote: Dear Peter I think we are discussing two different things here... 1. The violation (more...)