Dear Atul, Dear passionate-about-unit-testing-developers ;-), Sorry for the delayed replay, I wanted to take my time to write down my thoughts hoping to open a discussion. Actually I'm not addressing the new (more...)

I agree with you we should use typedefs! What about keeping the style for class names and name it BItemPtr or BItemPointer. I've read somewhere, sorry I can provide a (more...)

Hey Atul, the patch looks quite neat! This is much better than the old version. I think that using BinaryReader::readString() would make the resulting code even shorter. Btw we should be (more...)

Hi Atul, I mean not to bother with creating a decorator just because of a single ASCII parsing function. We should keep the idea in mind and realize it when/if we (more...)

Sorry it should be typedef std::auto_ptr BItem_Ptr; typo ;-) --- cheers atul atul wrote: Dear all class BDecoder { typedef std::auto_ptr BItem_Ptr; .... return std::auto_ptr( new BErrorItem ); return BItem_Ptr( new BErrorItem ); --- cheers (more...)

Dear all class BDecoder { typedef std::auto_ptr BItem_Ptr; ....       return std::auto_ptr( new BErrorItem ); return BItem_Ptr( new BErrorItem ); --- cheers atul

Dear all As per Peter's suggestion, I moved the readInt() back to BDecoder.... Let me know ... ---- cheers atul

Dear all Would like to share this tidbit... ~/calitko-0.5.6-refactored> cd **/BDecoder.cpp(:h) ~/calitko-0.5.6-refactored/Protocols/BitTorrent/Torrents> changes to the dir where somefile.cpp lives... amazing... this shell is full of surprises ;-) Another gem is that Ctrl-O instead of (more...)

Hey Peter In bold... Peter Dimov wrote: Hi Atul, What about that: instead of adding this new readInt() to BinaryReader, add a new parseInt() or extractInt() or readAsciiInt() as a private helper to BDecoder? (more...)

Hi Atul, What about that: instead of adding this new readInt() to BinaryReader, add a new parseInt() or extractInt() or readAsciiInt() as a private helper to BDecoder? This way BDecoder would (more...)