Archive for 22. November 2006

Kad Branch Updated
Hi all, just let you know that there's a new revision in the Kad branch (http://bzr.calitko.org/developers/david/calitko-Kad). I've added some new packets and corrected some errors. Next steps will involve writing more (more...)
Re: Re: Re: SourceComment: BDecoder::readInt()
hi, I think what Atul means is that there is no need to make extensive encapsulation: a wrapper is good if you want to change the output of a method to (more...)
Re: Re: SourceComment: BDecoder::readInt()
I'm a bit confused, Atul! Are you talking about BDecoder or BinaryReader? Could you elaborate your point a bit please? Regards, Peter Peter Dimov wrote:Hi Atul, the thing is that with integers (more...)
Re: SourceComment: BDecoder::readInt()
Hi Atul, the thing is that with integers we might need to swap bytes whereas readBytes() and readCString() should never swap bytes. Or maybe I got you wrong? Peter atul wrote:Dear all Why (more...)
SourceComment: BDecoder::readInt()
Dear all Why not use int QByteArray::toInt() and leave all the processing to it? ;-) I mean we could write a BinaryReader::toInt() wrapper and that could just call the QByteArray version.... So there would (more...)
Re: Re: Re: Re: SourceComment: BinaryReader - Remove duplication ;-)
Ahh, I should have saved the file after deleting the inline from the functions! The correct revision is 80. Peter Dimov wrote:Hi Atul, Thanks for the comments! I see your point about (more...)
Re: Re: Re: SourceComment: BinaryReader - Remove duplication ;-)
Hi Atul, Thanks for the comments! I see your point about inlining... it’s kind of premature optimization. I removed the inlines and committed the patch in revno 79 ;-). Regards, Peter atul wrote:Dear Peter, I (more...)
Re: Re: SourceComment: BinaryReader - Remove duplication ;-)
Dear Peter, I totally agree with you about the assert.... About copyBytes, I would leave it in... as it is more readable and one very good rule to follow is being cohesive... (more...)