Archive for 9. November 2006

Changes applied to BDecoder
Hi everyone, here is the new version of the BDecoder. I think I did all the changes we discussed, the use of auto_ptr and some other small changes. Slavcho
Re: BitTorrent::Packets::Packet refactoring
Hello everybody, I made two functions pure virtual just before committing after I saw the \todos in the patch and fixed right away. Just find out the unit tests can't compile (more...)
BitTorrent::Packets::Packet refactoring
Hello everybody, Here is the next patch of my BitTorrent development sequence. This time I was inspired by Atul’s processPayload() function. I thought it could be perfectly mapped to readPayload()of the (more...)
Re: Re: Re: Packets refactoring — first cut — RFC and not for commit
Hi Atul, Well, Packet is not really an interface although it is an abstract class. It provides implementation for some very basic packet functionality and declares some pure virtual functions, which (more...)
Re: Re: Is there any reason for…
Dear Peter, My replies in bold Take a look at the new base class Protocols::Generics::Packet and e.g. the base class for BitTorrent packets Protocols::BitTorrent::Packets::Packet. I think I should start using bzr In a nutshell (more...)
Re: Re: Packets refactoring — first cut — RFC and not for commit
Dear Peter My replies in bold Peter Dimov wrote: Hi Atul, you’ve done quite some work! Thanks mate I agree that isValid() should be removed! If we use the new version of parse() that gets (more...)