Archive for 7. November 2006

Re: Packets refactoring — first cut — RFC and not for commit
Hi Atul, you’ve done quite some work! I agree that isValid() should be removed! If we use the new version of parse() that gets called from the abstract PacketFactory, then we (more...)
Re: Is there any reason for…
Hi Atul, Yes, that's wrong and you are right. I didn't get reference counting quite right at first when I implemented the first Gnutella packets. I guess you already know what (more...)
Re: Re: dependencies getting screwed up
Hi Atul, Yes, dependencies got messed up when you change the includes of a file because Makefile does not get rebuilt. It is necessary to run qmake again to create an (more...)
Packets refactoring — first cut — RFC and not for commit
Hi all as this needs some more polishing.. the major change is removal of isValid and putting in the null object pattern... how does it look .... --cheerio atul
Is there any reason for…
reference counting Packet base class ( as there could be no object as it is not concrete ) and reference counting the concrete packets ( like pong ? ) I was wondering (more...)
Re: dependencies getting screwed up
Could be my failing ( as I introduced a new header - BadPacket.h -- ) and did not run qmake... but still the code was should still have worked ( as (more...)
dependencies getting screwed up
Dear all While refactoring Gnutella/Packets/Packet and friends I made changes and gave it a go... Somehow it started crashing mysteriously.. ( Data d member of Packet was not getting set ).. I (more...)