Hi Atul, You mean that the implementation of the pure virtual createPacket() should be allowed to return e.g. Protocols::Gnutella::Packets::BadPacket instead of Protocols::Generics::BadPacket? What would be different between the bad packets of (more...)

Hi Atul, Thanks for the comments! The patch was actually for my development BitTorrent branch, not the official one. I wanted to wait for more feedback before merging it there. Have (more...)

Dear all I think the createPacket function itself should call the parse function ( so it can completely determine the kind of packet to return ) So only createPacket would remain.. A little (more...)

Dear Peter I was not able to extract the patch on the source branch ... However I could read it fine... You have a great idea there and yes that is what (more...)

Hi Atul, Thanks for the patch! Just committed it in revno 68. I decided to save a roundtrip and changed indentation (maybe you used tab size of 2), fixed a memory (more...)