Archive for 11. October 2006

Re: Re: A possible race condition in Packet::invalidateHeader()
Dear Peter My response in bold Peter Dimov wrote: Hi Atul, Did you verify that a race occurs? Not with some tool like DRDT on solaris 10 ( Btw, it is a great tool and (more...)
Re: Refactored Packet::invalidateHeader()
Thanks Atul! Committed in revno 61! I'll look at the new tests a bit later today and write you back, gotta go right now. atul wrote:Dear all Here is the patch... tested with (more...)
Re: A possible race condition in Packet::invalidateHeader()
Hi Atul, Did you verify that a race occurs? I that should not be the case. QBasicAtomic::ref() and QBasicAtomic::deref() are atomic operations. if (!x->ref.deref()) delete x; The implementation of deref() (more...)
Re: MSVC project update for rev58
Hi Valeriy, Thanks for the patch! The usings you've added are fine! I know I told you that I will not be committing any further project structure changes before the 0.5.5 source (more...)
Re: QueryRouting Package fixes
Thanks a lot Rajesh! Comitted your patch in revno 60! Rajesh S.R wrote:Hi, Here are the QueryRouting Package fixes: *)The files QrtExchanger.{h|cpp},QrtReader.{h|cpp} QrtWriter.{h|cpp} QueryRoutingTable.{h|cpp} have been moved to the new package Gnutella/PacketProcessing/QueryRouting/ *)Modified (more...)
Improved documentation
This patch further improves the stylesheet of the documentation and extends the contents of some pages. The new version will soon be available at http://doc.calitko.org. Revno is (more...)
A possible race condition in Packet::invalidateHeader()
Dear all While doing the refactoring of this function, the race poped out .... ;-) if (!x->ref.deref()) delete x; Now what happens thread T1 has finish checking the above conditional and is then (more...)
Refactored Packet::invalidateHeader()
Dear all Here is the patch... tested with the unit tests sent in previous posts ;-) ---cheers atul
Some more tests added
And a little bit removed ( some test that did not make much sense ;-) Also I have put in Peter's changes... Here it goes... --- cheers atul
MSVC project update for rev58
I updated MS Studio project in rev58: Fixed "Protocols" directory Updated Debug configuration I had have to add "using" in 2 places - not sure that is correct, Peter, could you check?