Hello everybody, I thought it would be nice to open a discussion by presenting my view of coding styles/conventions for Calitko project. Most of you maybe already know that there is (more...)

Dear all Here is my first attempt... The source change is just the main function in main.cpp is not compiled... Thru a -DUNIT_TEST define. I am deliberately failing a test so you (more...)

atul wrote:... I’m quite sure your function and similar ones can be used on other places as well so we should make sure we reuse them! Sure... Also let me know (more...)

... Peter Dimov wrote: No, your changes are fine! Sorry I failed to mention that! Please send me a patch to apply in the mainstream. No Problems mate ... I will make a (more...)

Well, I would say that QueryHitsPrivate is a POD by design. Although it is a class, it is used like a struct and maybe should better be declared as one! (more...)

No, your changes are fine! Sorry I failed to mention that! Please send me a patch to apply in the mainstream. Another thing I failed to mention in the previous (more...)

Dear all         QueryHits::readPayload seems to be more interested in struct private.. Instead of pulling out the innards of private and filling them, we can push the stream to private... void QueryHits::readPayload (more...)

... Peter Dimov wrote: ..... P.S. I wouldn’t like to change too much Gnutella::Packets just for the sake of experimentation. .... Are you referring to the changes  ( or kind of changes ) like (more...)

Hello everybody, It's nice you brought up this topic, Atul! I think some good things can be done in regard to prepareReadPayload(). The original idea was to separate validation of packet (more...)

Hi Anders! Thanks for the patch => revision 45! ... Anders wrote:Reordering of member initialization in Gnutella::LocalPeer to get rid of annoying warnings.