Hi,   I agree with Peter, coding convention helps in understanding the code, make it more readable... Whatever convention is adopted , it needs to be consistant trhough the whole document. So it (more...)

Hello everybody! This is a continuation of the discussion we started with Atul regarding improvements in packet parsing. Before starting actual coding I’d like to present you my improvements ideas and (more...)

Hi Atul, You are right that name() should be a pure virtual. It was just a fast hack some long time ago when I needed to dump some debug info. name() (more...)

Thanks for the patch! Committed in revno 47. Just corrected the whitespaces and added \todo to the comments regarding the literal constant 11 and size_t, so that they be listed (more...)

Hi Atul, I didn't actually know such programs exist... although that should be a quite logical expectation ;-). Cool name for that kind of progs - beautifiers ;-) I'll take a look (more...)

Hello everybody! Thanks to Atul who pointed me to CppUnit and provided a sample unit test for Gnutella::Packets::Bye + Makefile! I just finished a qmake project for CppUnit (built as library), to (more...)

Dear all I think it would be easier to make name() a pure virtual ... So the compiler makes sure we provide a name ;-) Switch/case is really against OO... I think Packet::fromRawData (more...)

Here is the patch ;-) I have changed the function name to findCString

... Dear Peter I think the points you raised are very relevant .. and I hope many  are addressed by GNU indent.... This is one great program... Whenever I need to look into (more...)

Thanks for the files, Atul! I took a quick look into what you’ve done and it looks quite neat! I also read the CppUnit Cookbook which explains the basics (more...)